Tracker 836: Add facility to change output file-name for a \book block

classic Classic list List threaded Threaded
19 messages Options
Reply | Threaded
Open this post in threaded view
|

Tracker 836: Add facility to change output file-name for a \book block

Ian Hulin
Reviewers: Neil Puttock,

Description:
Tracker 836: Add facility to change output file-name for a \book block

or to set a suffix to prevent multiple files over-writing each other
during
a compilation.
This change allows user to to this via functions rather than having to
do
so by manipulating semi-documented parser variables.

ignore .gitignore

Please review this at http://codereview.appspot.com/144047

Affected files:
   M .gitignore
   M lily/parser.yy
   M ly/init.ly
   M ly/music-functions-init.ly
   M scm/lily-library.scm



---

----
Join the Frogs!

Reply | Threaded
Open this post in threaded view
|

Re: Tracker 836: Add facility to change output file-name for a \book block

Neil Puttock
Hi Ian,

I haven't commented on lily-library.scm, since there are too many
formatting issues.

I'd suggest installing emacs to sort out the indentation (even if you
prefer to use another editor for your main work), otherwise we're going
to spend ages pointing out every little nitpick when we should be
focusing on the code.

Cheers,
Neil


http://codereview.appspot.com/143055/diff/10/1004
File lily/parser.yy (left):

http://codereview.appspot.com/143055/diff/10/1004#oldcode659
Line 659: }
I've always found the formatting in parser.yy rather strange, but it's
consistent, so you should revert this change.

http://codereview.appspot.com/143055/diff/10/1004
File lily/parser.yy (right):

http://codereview.appspot.com/143055/diff/10/1004#newcode676
Line 676: PARSER->lexer_->set_identifier (ly_symbol2scm
("book-output-suffix"), SCM_BOOL_F);
trailing space

http://codereview.appspot.com/143055/diff/10/1004#newcode677
Line 677: PARSER->lexer_->set_identifier (ly_symbol2scm
("book-filename"), SCM_BOOL_F);
trailing space

http://codereview.appspot.com/143055/diff/10/1005
File ly/init.ly (right):

http://codereview.appspot.com/143055/diff/10/1005#newcode14
Line 14: #(define toplevel-bookparts (list))
trailing space

http://codereview.appspot.com/143055/diff/10/1006
File ly/music-functions-init.ly (left):

http://codereview.appspot.com/143055/diff/10/1006#oldcode182
Line 182:
restore

These spaces were added when the file was sorted alphabetically.

http://codereview.appspot.com/143055/diff/10/1006#oldcode183
Line 183:
restore

http://codereview.appspot.com/143055/diff/10/1006#oldcode591
Line 591: pitchedTrill =
I'm afraid this is a bit of a mess.

http://codereview.appspot.com/143055/diff/10/1006
File ly/music-functions-init.ly (right):

http://codereview.appspot.com/143055/diff/10/1006#newcode17
Line 17: #(define (void-make-music)
Like Carl's said, it's fine leaving this for another patch.

A few pointers:

For consistency with the other helper functions, it should be named
make-void-music

It should go in music-functions.scm

It should be define-public

http://codereview.appspot.com/143055/diff/10/1006#newcode176
Line 176: 'delta-step delta))
should be aligned with 'BendAfterEvent

http://codereview.appspot.com/143055/diff/10/1006#newcode180
Line 180: (_i "Direct output for the current book block to
@var{newfilename}")
full stop after @var{newfilename}

http://codereview.appspot.com/143055/diff/10/1006#newcode187
Line 187: @var{newsuffix}")
full stop after @var{newsuffix}

http://codereview.appspot.com/143055/diff/10/1006#newcode604
Line 604: (list part1 part2)))
aligns with parser

http://codereview.appspot.com/143055/diff/10/1006#newcode648
Line 648: 'element main-music
This and the following lines should be aligned with 'QuoteMusic.

http://codereview.appspot.com/143055

---

----
Join the Frogs!

Reply | Threaded
Open this post in threaded view
|

Re: Tracker 836: Add facility to change output file-name for a \book block

Ian Hulin
In reply to this post by Ian Hulin

http://codereview.appspot.com/143055/diff/10/1005
File ly/init.ly (right):

http://codereview.appspot.com/143055/diff/10/1005#newcode14
Line 14: #(define toplevel-bookparts (list))
On 2009/10/29 21:14:17, Neil Puttock wrote:
> trailing space

Done.

http://codereview.appspot.com/143055/diff/10/1006
File ly/music-functions-init.ly (left):

http://codereview.appspot.com/143055/diff/10/1006#oldcode182
Line 182:
On 2009/10/29 21:14:17, Neil Puttock wrote:
> restore

> These spaces were added when the file was sorted alphabetically.

Done.

http://codereview.appspot.com/143055/diff/10/1006#oldcode183
Line 183:
On 2009/10/29 21:14:17, Neil Puttock wrote:
> restore

Done.

http://codereview.appspot.com/143055/diff/10/1006
File ly/music-functions-init.ly (right):

http://codereview.appspot.com/143055/diff/10/1006#newcode17
Line 17: #(define (void-make-music)
On 2009/10/29 21:14:17, Neil Puttock wrote:
> Like Carl's said, it's fine leaving this for another patch.

> A few pointers:

> For consistency with the other helper functions, it should be named
> make-void-music

> It should go in music-functions.scm

> It should be define-public

Done.  (left as a TODO: for future patch)

http://codereview.appspot.com/143055/diff/10/1006#newcode176
Line 176: 'delta-step delta))
On 2009/10/29 21:14:17, Neil Puttock wrote:
> should be aligned with 'BendAfterEvent

Done.

http://codereview.appspot.com/143055/diff/10/1006#newcode180
Line 180: (_i "Direct output for the current book block to
@var{newfilename}")
On 2009/10/29 21:14:17, Neil Puttock wrote:
> full stop after @var{newfilename}

Done.

http://codereview.appspot.com/143055/diff/10/1006#newcode187
Line 187: @var{newsuffix}")
On 2009/10/29 21:14:17, Neil Puttock wrote:
> full stop after @var{newsuffix}

Done.

http://codereview.appspot.com/143055

---

----
Join the Frogs!

Reply | Threaded
Open this post in threaded view
|

Re: Re: Tracker 836: Add facility to change output file-name for a \book block

Carl Sorensen
In reply to this post by Neil Puttock



On 10/29/09 3:14 PM, "[hidden email]" <[hidden email]> wrote:

> Hi Ian,
>
> I haven't commented on lily-library.scm, since there are too many
> formatting issues.
>
> I'd suggest installing emacs to sort out the indentation (even if you
> prefer to use another editor for your main work), otherwise we're going
> to spend ages pointing out every little nitpick when we should be
> focusing on the code.

vim also does a decent job of indenting scheme code, and automatically
strips trailing whitespace if you set it to.

I'm not trying to start a vim/emacs flame war.  Just mentioning another
option.

Carl


---

----
Join the Frogs!

Reply | Threaded
Open this post in threaded view
|

Re: Re: Tracker 836: Add facility to change output file-name for a \book block

Graham Percival
On Thu, Oct 29, 2009 at 06:00:06PM -0600, Carl Sorensen wrote:

>
> On 10/29/09 3:14 PM, "[hidden email]" <[hidden email]> wrote:
>
> > I'd suggest installing emacs to sort out the indentation (even if you
> > prefer to use another editor for your main work), otherwise we're going
> > to spend ages pointing out every little nitpick when we should be
> > focusing on the code.
>
> vim also does a decent job of indenting scheme code, and automatically
> strips trailing whitespace if you set it to.

Yes, but the official lilypond formatting is "whatever emacs does,
plus one or two other scripts to tweak a few more things".

I'd love it if any frog wants to look at the code
formatting/syntax issue.  I mean, it's definitely annoying /
slowing down actual bugfixes and new features.

Cheers,
- Graham

---

----
Join the Frogs!

Reply | Threaded
Open this post in threaded view
|

Re: Re: Tracker 836: Add facility to change output file-name for a \book block

Carl Sorensen



On 10/29/09 6:10 PM, "Graham Percival" <[hidden email]> wrote:

> On Thu, Oct 29, 2009 at 06:00:06PM -0600, Carl Sorensen wrote:
>>
>> On 10/29/09 3:14 PM, "[hidden email]" <[hidden email]> wrote:
>>
>>> I'd suggest installing emacs to sort out the indentation (even if you
>>> prefer to use another editor for your main work), otherwise we're going
>>> to spend ages pointing out every little nitpick when we should be
>>> focusing on the code.
>>
>> vim also does a decent job of indenting scheme code, and automatically
>> strips trailing whitespace if you set it to.
>
> Yes, but the official lilypond formatting is "whatever emacs does,
> plus one or two other scripts to tweak a few more things".

vim's scheme code indenting is the same as "whatever emacs does".

Carl


---

----
Join the Frogs!

Reply | Threaded
Open this post in threaded view
|

Re: Re: Tracker 836: Add facility to change output file-name for a \book block

Ian Hulin
Hi all,
I've installed emacs and checked the indenting as per Carl and Neils recommendations.  Patch set has been on rietveld 143055 for some days. 

Is this ready to push now?

Cheers,
Ian


Carl Sorensen wrote:

On 10/29/09 6:10 PM, "Graham Percival" [hidden email] wrote:

  
On Thu, Oct 29, 2009 at 06:00:06PM -0600, Carl Sorensen wrote:
    
On 10/29/09 3:14 PM, [hidden email] [hidden email] wrote:

      
I'd suggest installing emacs to sort out the indentation (even if you
prefer to use another editor for your main work), otherwise we're going
to spend ages pointing out every little nitpick when we should be
focusing on the code.
        
vim also does a decent job of indenting scheme code, and automatically
strips trailing whitespace if you set it to.
      
Yes, but the official lilypond formatting is "whatever emacs does,
plus one or two other scripts to tweak a few more things".
    

vim's scheme code indenting is the same as "whatever emacs does".

Carl

  

Reply | Threaded
Open this post in threaded view
|

Re: Re: Tracker 836: Add facility to change output file-name for a \book block

Patrick McCarty
On 2009-11-03, Ian Hulin wrote:
> Hi all,
> I've installed emacs and checked the indenting as per Carl and Neils
> recommendations.  Patch set has been on rietveld 143055 for some
> days.
>
> Is this ready to push now?

Hi Ian,

The indentation in lily-library.scm is still very weird in several
spots.  I'll point some of them out on Rietveld.

-Patrick

---

----
Join the Frogs!

Reply | Threaded
Open this post in threaded view
|

Re: Tracker 836: Add facility to change output file-name for a \book block

Patrick McCarty
In reply to this post by Ian Hulin

http://codereview.appspot.com/143055/diff/19/1020
File scm/lily-library.scm (right):

http://codereview.appspot.com/143055/diff/19/1020#newcode99
Line 99: (for-each (lambda (symbol)
I would recommend indenting like so:

   (for-each
     (lambda (symbol)
       (let ((..

http://codereview.appspot.com/143055/diff/19/1020#newcode142
Line 142: (if (not book-filename)
The if block should be indented two more spaces here.

http://codereview.appspot.com/143055/diff/19/1020#newcode143
Line 143: (ly:parser-output-name parser)
These two lines should begin in the same column as (not ...)

http://codereview.appspot.com/143055/diff/19/1020#newcode149
Line 149: (let ((book-output-suffix (ly:parser-lookup parser
'book-output-suffix)))
indent the if block

http://codereview.appspot.com/143055/diff/19/1020#newcode151
Line 151: (ly:parser-lookup parser 'output-suffix)
align these with (not ...)

http://codereview.appspot.com/143055

---

----
Join the Frogs!

Reply | Threaded
Open this post in threaded view
|

Re: Tracker 836: Add facility to change output file-name for a \book block

Patrick McCarty
In reply to this post by Ian Hulin

http://codereview.appspot.com/143055/diff/19/1020
File scm/lily-library.scm (right):

http://codereview.appspot.com/143055/diff/19/1020#newcode99
Line 99: (for-each (lambda (symbol)
I would recommend indenting like so:

   (for-each
     (lambda (symbol)
       (let ((..

http://codereview.appspot.com/143055/diff/19/1020#newcode142
Line 142: (if (not book-filename)
The if block should be indented two more spaces here.

http://codereview.appspot.com/143055/diff/19/1020#newcode143
Line 143: (ly:parser-output-name parser)
These two lines should begin in the same column as (not ...)

http://codereview.appspot.com/143055/diff/19/1020#newcode149
Line 149: (let ((book-output-suffix (ly:parser-lookup parser
'book-output-suffix)))
indent the if block

http://codereview.appspot.com/143055/diff/19/1020#newcode151
Line 151: (ly:parser-lookup parser 'output-suffix)
align these with (not ...)

http://codereview.appspot.com/143055

---

----
Join the Frogs!

Reply | Threaded
Open this post in threaded view
|

Re: Tracker 836: Add facility to change output file-name for a \book block

Patrick McCarty
In reply to this post by Ian Hulin
http://codereview.appspot.com/143055

---

----
Join the Frogs!

Reply | Threaded
Open this post in threaded view
|

Re: Tracker 836: Add facility to change output file-name for a \book block

Patrick McCarty
In reply to this post by Ian Hulin
http://codereview.appspot.com/143055

---

----
Join the Frogs!

Reply | Threaded
Open this post in threaded view
|

Re: Tracker 836: Add facility to change output file-name for a \book block

Carl.D.Sorensen
In reply to this post by Ian Hulin
Ian,

I found some indentation errors in the .ly file.

Thanks for your patience,

Carl



http://codereview.appspot.com/143055/diff/19/1019
File ly/music-functions-init.ly (right):

http://codereview.appspot.com/143055/diff/19/1019#newcode616
Line 616: (let* ( (get-notes (lambda (ev-chord)
eliminate space between ( (, and align the following lines

http://codereview.appspot.com/143055/diff/19/1019#newcode626
Line 626: (let*(  (trill-pitch (ly:music-property (car sec-note-events)
'pitch))
space after let*, no space before (trill-pitch

http://codereview.appspot.com/143055/diff/19/1019#newcode628
Line 628: 'force-accidental)))
This alignment isn't right.  'force-accidental should align with (car

http://codereview.appspot.com/143055/diff/19/1019#newcode630
Line 630: (if (ly:pitch? trill-pitch)
(if should align with e in let*

http://codereview.appspot.com/143055/diff/19/1019#newcode632
Line 632: (ly:music-set-property! m 'pitch trill-pitch)) trill-events)
should be indented relative to lambda

http://codereview.appspot.com/143055/diff/19/1019#newcode638
Line 638: (for-each (lambda (m)
align with (eq?

http://codereview.appspot.com/143055/diff/19/1019#newcode639
Line 639: (ly:music-set-property! m 'force-accidental forced))
align with (eq?

http://codereview.appspot.com/143055

---

----
Join the Frogs!

Reply | Threaded
Open this post in threaded view
|

Re: Tracker 836: Add facility to change output file-name for a \book block

Neil Puttock
In reply to this post by Ian Hulin
Hi Ian,

Carl's already commented on \pitchedTrill, but there's absolutely
nothing wrong with its current indentation; the only thing that you
might change is the newline after the let*.

Regards,
Neil


http://codereview.appspot.com/143055/diff/19/1017
File lily/parser.yy (right):

http://codereview.appspot.com/143055/diff/19/1017#newcode676
Line 676: PARSER->lexer_->set_identifier (ly_symbol2scm
("book-filename"), SCM_BOOL_F);
There are a few spaces between tabs here, i.e.,

[tab][spaces][tab]

iso

[tab][tab][spaces]

http://codereview.appspot.com/143055/diff/19/1019
File ly/music-functions-init.ly (right):

http://codereview.appspot.com/143055/diff/19/1019#newcode16
Line 16: %% TODO: Move this declaration to music-functions.scm
Please remove this completely.

http://codereview.appspot.com/143055/diff/19/1020
File scm/lily-library.scm (right):

http://codereview.appspot.com/143055/diff/19/1020#newcode99
Line 99: (for-each (lambda (symbol)
On 2009/11/04 01:06:34, Patrick McCarty wrote:
> I would recommend indenting like so:

>    (for-each
>      (lambda (symbol)
>        (let ((..

I'd recommend reverting the changes, since there's absolutely nothing
wrong with how this is currently indented. :)

http://codereview.appspot.com/143055

---

----
Join the Frogs!

Reply | Threaded
Open this post in threaded view
|

Re: Tracker 836: Add facility to change output file-name for a \book block

Ian Hulin
In reply to this post by Ian Hulin
lily-library.scm changes after Patrick's feedback.


http://codereview.appspot.com/143055/diff/19/1020
File scm/lily-library.scm (right):

http://codereview.appspot.com/143055/diff/19/1020#newcode142
Line 142: (if (not book-filename)
On 2009/11/04 01:06:34, Patrick McCarty wrote:
> The if block should be indented two more spaces here.

Done.

http://codereview.appspot.com/143055/diff/19/1020#newcode143
Line 143: (ly:parser-output-name parser)
On 2009/11/04 01:06:34, Patrick McCarty wrote:
> These two lines should begin in the same column as (not ...)

Done.

http://codereview.appspot.com/143055/diff/19/1020#newcode149
Line 149: (let ((book-output-suffix (ly:parser-lookup parser
'book-output-suffix)))
On 2009/11/04 01:06:34, Patrick McCarty wrote:
> indent the if block

Done.

http://codereview.appspot.com/143055

---

----
Join the Frogs!

Reply | Threaded
Open this post in threaded view
|

Re: Tracker 836: Add facility to change output file-name for a \book block

Ian Hulin
In reply to this post by Ian Hulin
Thanks for the feedback.  Is the now patch readu to push now?

Cheers,
Ian


http://codereview.appspot.com/143055/diff/19/1017
File lily/parser.yy (right):

http://codereview.appspot.com/143055/diff/19/1017#newcode676
Line 676: PARSER->lexer_->set_identifier (ly_symbol2scm
("book-filename"), SCM_BOOL_F);
On 2009/11/04 18:21:47, Neil Puttock wrote:
> There are a few spaces between tabs here, i.e.,

> [tab][spaces][tab]

> iso

> [tab][tab][spaces]




Done.

http://codereview.appspot.com/143055/diff/19/1019
File ly/music-functions-init.ly (right):

http://codereview.appspot.com/143055/diff/19/1019#newcode16
Line 16: %% TODO: Move this declaration to music-functions.scm
On 2009/11/04 18:21:47, Neil Puttock wrote:
> Please remove this completely.

Done.

http://codereview.appspot.com/143055/diff/19/1019#newcode616
Line 616: (let* ( (get-notes (lambda (ev-chord)
On 2009/11/04 04:31:44, Carl wrote:
> eliminate space between ( (, and align the following lines

Done.

http://codereview.appspot.com/143055/diff/19/1019#newcode626
Line 626: (let*(  (trill-pitch (ly:music-property (car sec-note-events)
'pitch))
On 2009/11/04 04:31:44, Carl wrote:
> space after let*, no space before (trill-pitch

Done.

http://codereview.appspot.com/143055/diff/19/1019#newcode628
Line 628: 'force-accidental)))
On 2009/11/04 04:31:44, Carl wrote:
> This alignment isn't right.  'force-accidental should align with (car

Done.

http://codereview.appspot.com/143055/diff/19/1019#newcode630
Line 630: (if (ly:pitch? trill-pitch)
On 2009/11/04 04:31:44, Carl wrote:
> (if should align with e in let*

Done.

http://codereview.appspot.com/143055/diff/19/1019#newcode632
Line 632: (ly:music-set-property! m 'pitch trill-pitch)) trill-events)
On 2009/11/04 04:31:44, Carl wrote:
> should be indented relative to lambda

Done.

http://codereview.appspot.com/143055/diff/19/1019#newcode638
Line 638: (for-each (lambda (m)
On 2009/11/04 04:31:44, Carl wrote:
> align with (eq?

Done.

http://codereview.appspot.com/143055/diff/19/1019#newcode639
Line 639: (ly:music-set-property! m 'force-accidental forced))
On 2009/11/04 04:31:44, Carl wrote:
> align with (eq?

Shouldn't this indent form (lambda (m) as it's the procedure body
declaration?

http://codereview.appspot.com/143055/diff/19/1020
File scm/lily-library.scm (right):

http://codereview.appspot.com/143055/diff/19/1020#newcode99
Line 99: (for-each (lambda (symbol)
On 2009/11/04 01:06:34, Patrick McCarty wrote:
> I would recommend indenting like so:

>    (for-each
>      (lambda (symbol)
>        (let ((..

Done.

http://codereview.appspot.com/143055/diff/19/1020#newcode99
Line 99: (for-each (lambda (symbol)
On 2009/11/04 18:21:47, Neil Puttock wrote:
> On 2009/11/04 01:06:34, Patrick McCarty wrote:
> > I would recommend indenting like so:
> >
> >   (for-each
> >     (lambda (symbol)
> >       (let ((..

> I'd recommend reverting the changes, since there's absolutely nothing
wrong with
> how this is currently indented. :)
Didn't get your e-mail until after I'd implemented Patrick's.  Sorry

http://codereview.appspot.com/143055/diff/19/1020#newcode151
Line 151: (ly:parser-lookup parser 'output-suffix)
On 2009/11/04 01:06:34, Patrick McCarty wrote:
> align these with (not ...)

Done.

http://codereview.appspot.com/143055

---

----
Join the Frogs!

Reply | Threaded
Open this post in threaded view
|

Re: Tracker 836: Add facility to change output file-name for a \book block

Neil Puttock
In reply to this post by Ian Hulin
On 2009/11/04 23:03:27, Ian Hulin wrote:
> Thanks for the feedback.  Is the now patch readu to push now?

There are several lines with trailing spaces.

You've reverted some recent changes in lily-library.scm which breaks
compilation; see `flatten-list' and `eval-carefully'.

Regards,
Neil

http://codereview.appspot.com/143055

---

----
Join the Frogs!

Reply | Threaded
Open this post in threaded view
|

Re: Tracker 836: Add facility to change output file-name for a \book block

Neil Puttock
In reply to this post by Ian Hulin

http://codereview.appspot.com/143055/diff/2010/2013
File ly/music-functions-init.ly (left):

http://codereview.appspot.com/143055/diff/2010/2013#oldcode604
Line 604: (ly:music-property main-note 'elements))))
goes with (lambda

http://codereview.appspot.com/143055/diff/2010/2013
File ly/music-functions-init.ly (right):

http://codereview.appspot.com/143055/diff/2010/2013#newcode611
Line 611: (filter
goes with `a' in (lambda

http://codereview.appspot.com/143055/diff/2010/2013#newcode612
Line 612: (lambda (m) (eq? 'NoteEvent (ly:music-property m 'name)))
goes with filter

http://codereview.appspot.com/143055/diff/2010/2013#newcode613
Line 613: (ly:music-property ev-chord 'elements))))
same as above

http://codereview.appspot.com/143055/diff/2010/2013#newcode614
Line 614: (sec-note-events (get-notes secondary-note))
goes with (get-notes

http://codereview.appspot.com/143055/diff/2010/2013#newcode615
Line 615: (trill-events (filter (lambda (m) (music-has-type m
'trill-span-event))
as above

http://codereview.appspot.com/143055/diff/2010/2013#newcode618
Line 618: (if (pair? sec-note-events)
goes with `e' in (let*

http://codereview.appspot.com/143055/diff/2010/2013#newcode619
Line 619: (begin
aligns with (pair?

http://codereview.appspot.com/143055/diff/2010/2013#newcode621
Line 621: (forced (ly:music-property (car sec-note-events )
(car sec-note-events)

http://codereview.appspot.com/143055/diff/2010/2013#newcode631
Line 631: (if (eq? forced #t)
same level as (if (ly:pitch? trill-pitch)

http://codereview.appspot.com/143055/diff/2010/2013#newcode634
Line 634: trill-events)))))
aligns with (lambda

http://codereview.appspot.com/143055/diff/2010/2013#newcode635
Line 635: main-note))
unindent to same level as (if (pair? sec-note-events)

http://codereview.appspot.com/143055/diff/2010/2014
File scm/lily-library.scm (right):

http://codereview.appspot.com/143055/diff/2010/2014#newcode102
Line 102: (if (symbol? permission)
aligns with `e' in (let

http://codereview.appspot.com/143055/diff/2010/2014#newcode175
Line 175: "[^-[:alnum:]]"
goes with `s' in string-regexp-substitute

http://codereview.appspot.com/143055/diff/2010/2014#newcode176
Line 176: "_"
as above

http://codereview.appspot.com/143055/diff/2010/2014#newcode177
Line 177: output-suffix))))
as above

http://codereview.appspot.com/143055

---

----
Join the Frogs!

Reply | Threaded
Open this post in threaded view
|

Re: Tracker 836: Add facility to change output file-name for a \book block

Ian Hulin
In reply to this post by Neil Puttock
[hidden email] wrote:
> On 2009/11/04 23:03:27, Ian Hulin wrote:
>> Thanks for the feedback.  Is the now patch readu to push now?
>
> There are several lines with trailing spaces.
>
> You've reverted some recent changes in lily-library.scm which breaks
> compilation; see `flatten-list' and `eval-carefully'.
Re-fetched current master version of lily-library.scm from remote repo
and applied only the changes to print-book-with and functions it calls
from my version.

git-cl has created a new issue 150044 as I had to reinitialize and
re-fetch my git repository.

Will answer  all the points from your next e-mail on 143055.

Cheers,

Ian

>
> Regards,
> Neil
>
> http://codereview.appspot.com/143055
>
> ______________________________________________       This email has
> been scanned by Netintelligence      
> http://www.netintelligence.com/email
>
>



---

----
Join the Frogs!