Regression test file for Trackers 714 and 832

classic Classic list List threaded Threaded
12 messages Options
Reply | Threaded
Open this post in threaded view
|

Regression test file for Trackers 714 and 832

Ian Hulin
Hi Frogs,

Attached is a patch to add a regression test for generating files where the output names contain extended Latin characters (like š and č).

Do I only need to add the new file to git or is there another file I need to edit to get the regression test to pick it up?

CG chapter 7 (Regression Tests is almost totally uncontaminated with content).

Cheers,

Ian
Reply | Threaded
Open this post in threaded view
|

Re: Regression test file for Trackers 714 and 832

Patrick McCarty
Hi Ian,

On 2009-11-15, Ian Hulin wrote:
> Attached is a patch to add a regression test for generating files
> where the output names contain extended Latin characters (like š and
> č).

Did you forget the attach the patch?  I don't see it.

> Do I only need to add the new file to git or is there another file I
> need to edit to get the regression test to pick it up?

Adding the regression test to git is all that is necessary.

Thanks,
Patrick

---
----
Join the Frogs!

Reply | Threaded
Open this post in threaded view
|

Re: Regression test file for Trackers 714 and 832

Ian Hulin
Ooops.

Here's the patch this time

Sorry for the confusion.

Cheers

Ian Hulin


Patrick McCarty wrote:
Hi Ian,

On 2009-11-15, Ian Hulin wrote:
  
Attached is a patch to add a regression test for generating files
where the output names contain extended Latin characters (like š and
č).
    

Did you forget the attach the patch?  I don't see it.

  
Do I only need to add the new file to git or is there another file I
need to edit to get the regression test to pick it up?
    

Adding the regression test to git is all that is necessary.

Thanks,
Patrick

---
----
Join the Frogs!


______________________________________________        
This email has been scanned by Netintelligence        
http://www.netintelligence.com/email

  


From 1d4349effc5fb6fc865ac2be558fc61d44e5bb73 Mon Sep 17 00:00:00 2001
From: Ian Hulin <[hidden email]>
Date: Sun, 15 Nov 2009 19:58:55 +0000
Subject: [PATCH] Trackers 832 and 714 - add regression test for output file names containing
 extended Latin accents and other UTF-8 characters.

Signed-off-by: Ian Hulin <[hidden email]>
---
 input/regression/output-filenames-with-accents.ly |  190 +++++++++++++++++++++
 1 files changed, 190 insertions(+), 0 deletions(-)
 create mode 100644 input/regression/output-filenames-with-accents.ly

diff --git a/input/regression/output-filenames-with-accents.ly b/input/regression/output-filenames-with-accents.ly
new file mode 100644
index 0000000..0625b2f
--- /dev/null
+++ b/input/regression/output-filenames-with-accents.ly
@@ -0,0 +1,190 @@
+\version "2.13.5"
+
+\header {
+  texidoc = "Using extended Latin characters like Å¡ in
+  output file-names should not cause any problems with
+  backend processors.  We test this here by using such
+  characters in output-suffix"
+  dedication = "Lilypond Regression Test"
+  title = "Má Vlast"
+  subtitle = "Symphonic Tone Poem Cycle"
+  instrument = "Orchestra"
+  composer = "Bedřich Å metana"
+  opus = "Opus 64"
+}
+\version "2.13.5"
+
+
+globalI = {
+  \key c \major
+  \time 4/4
+}
+
+globalII = {
+  \key e \minor
+  \time 6/8
+}
+globalIII = {
+  \key f \minor
+  \time 4/4
+}
+globalIV = {
+  \key f \major
+  \time 4/4
+}
+globalV = {
+  \key d \minor
+  \time 4/4
+}
+globalVI = {
+  \key d \minor
+  \time 4/4
+}
+
+violinmI = \relative c'' {
+  \globalI
+  c4 c c c |
+}
+"output-suffix" = "Vyšehrad"
+\book {
+  \header {
+   subsubtitle = "I. VyÅ¡ehrad"
+  }
+  \score {
+    \new Staff \with {
+      instrumentName = "Violin"
+      midiInstrument = "violin"
+    } \violinmI
+    \layout { }
+    \midi {
+      \context {
+        \Score
+        tempoWholesPerMinute = #(ly:make-moment 100 4)
+      }
+    }
+  }
+}
+
+violinmII = \relative c'' {
+  \globalII
+  % Music follows here.
+  e4 e8 e4 e8 |
+}
+"output-suffix" = "Vltava"
+\book {
+  \header {
+   subsubtitle = "II. Vltava"
+  }
+  \score {
+    \new Staff \with {
+      instrumentName = "Violin"
+      midiInstrument = "violin"
+    } \violinmII
+    \layout { }
+    \midi {
+      \context {
+        \Score
+        tempoWholesPerMinute = #(ly:make-moment 100 4)
+      }
+    }
+  }
+}
+
+violinmIII = \relative c'' {
+  \globalIII
+  % Music follows here.
+  f4 f f f|
+}
+"output-suffix" = "Å arka"
+\book {
+  \header {
+   subsubtitle = "III. Å arka"
+  }
+  \score {
+    \new Staff \with {
+      instrumentName = "Violin"
+      midiInstrument = "violin"
+    } \violinmIII
+    \layout { }
+    \midi {
+      \context {
+        \Score
+        tempoWholesPerMinute = #(ly:make-moment 100 4)
+      }
+    }
+  }
+}
+
+violinmIV = \relative c'' {
+  \globalIV
+  % Music follows here.
+  d4 d d d |
+}
+"output-suffix" = "Z-českých-luhů-a-hájů"
+\book {
+  \header {
+   subsubtitle = "IV. Z českých luhů a hájů"
+  }
+  \score {
+    \new Staff \with {
+      instrumentName = "Violin"
+      midiInstrument = "violin"
+    } \violinmIV
+    \layout { }
+    \midi {
+      \context {
+        \Score
+        tempoWholesPerMinute = #(ly:make-moment 100 4)
+      }
+    }
+  }
+}
+
+violinmV = \relative c'' {
+  \globalV
+  % Music follows here.
+  d4 d d d |
+}
+"output-suffix" = "Tábor"
+\book {
+  \header {
+   subsubtitle = "V. Tábor"
+  }
+  \score {
+    \new Staff \with {
+      instrumentName = "Violin"
+      midiInstrument = "violin"
+    } \violinmV
+    \layout { }
+    \midi {
+      \context {
+        \Score
+        tempoWholesPerMinute = #(ly:make-moment 100 4)
+      }
+    }
+  }
+}
+violinmVI = \relative c'' {
+  \globalVI
+  % Music follows here.
+  d4 d d d |
+}
+"output-suffix" = "Blanik"
+\book {
+  \header {
+   subsubtitle = "VI. Blanik"
+  }
+  \score {
+    \new Staff \with {
+      instrumentName = "Violin"
+      midiInstrument = "violin"
+    } \violinmVI
+    \layout { }
+    \midi {
+      \context {
+        \Score
+        tempoWholesPerMinute = #(ly:make-moment 100 4)
+      }
+    }
+  }
+}
--
1.6.3.3

Reply | Threaded
Open this post in threaded view
|

Re: Regression test file for Trackers 714 and 832

Patrick McCarty
Hi Ian,

Your patch is saved in ASCII, but it should be saved in UTF-8.  I'll
provide some more comments for you below.

On 2009-11-16, Ian Hulin wrote:
> Ooops.
>
> Here's the patch this time
>
> Sorry for the confusion.

[patch follows]

> From 1d4349effc5fb6fc865ac2be558fc61d44e5bb73 Mon Sep 17 00:00:00 2001
> From: Ian Hulin <[hidden email]>
> Date: Sun, 15 Nov 2009 19:58:55 +0000
> Subject: [PATCH] Trackers 832 and 714 - add regression test for output file names containing
>  extended Latin accents and other UTF-8 characters.

Can you make sure the commit summary is concise enough to fit on one
line?  I would recommend something like

  Add regression test for issues 832 and 714.

and after adding two newlines, write and more verbose description, if
necessary, underneath the commit summary.

> Signed-off-by: Ian Hulin <[hidden email]>
> ---
>  input/regression/output-filenames-with-accents.ly |  190 +++++++++++++++++++++

I think it would be better if this regtest were named
"output-suffix.ly", because that is the only thing you are testing.

>  1 files changed, 190 insertions(+), 0 deletions(-)
>  create mode 100644 input/regression/output-filenames-with-accents.ly
>
> diff --git a/input/regression/output-filenames-with-accents.ly b/input/regression/output-filenames-with-accents.ly
> new file mode 100644
> index 0000000..0625b2f
> --- /dev/null
> +++ b/input/regression/output-filenames-with-accents.ly
> @@ -0,0 +1,190 @@
> +\version "2.13.5"
> +
> +\header {
> +  texidoc = "Using extended Latin characters like ?? in
> +  output file-names should not cause any problems with
> +  backend processors.  We test this here by using such
> +  characters in output-suffix"
> +  dedication = "Lilypond Regression Test"
> +  title = "M?? Vlast"
> +  subtitle = "Symphonic Tone Poem Cycle"
> +  instrument = "Orchestra"
> +  composer = "Bed??ich ??metana"
> +  opus = "Opus 64"

Is it really necessary to add an excerpt from an actual composition
when you are just testing output-suffix to make sure it works with
various UTF-8 characters?

> +}
> +\version "2.13.5"

You already have a \version statement at the beginning of the file.

> +
> +
> +globalI = {
> +  \key c \major
> +  \time 4/4
> +}
> +
> +globalII = {
> +  \key e \minor
> +  \time 6/8
> +}
> +globalIII = {
> +  \key f \minor
> +  \time 4/4
> +}
> +globalIV = {
> +  \key f \major
> +  \time 4/4
> +}
> +globalV = {
> +  \key d \minor
> +  \time 4/4
> +}
> +globalVI = {
> +  \key d \minor
> +  \time 4/4
> +}
> +
> +violinmI = \relative c'' {
> +  \globalI
> +  c4 c c c |
> +}
> +"output-suffix" = "Vy??ehrad"

For consistency, I would recommend writing this as

  #(define output-suffix "...")

instead.  IMO, it's cleaner and this is how it's used in the
documentation.  The question marks will go away once you have saved
the file in UTF-8.

[snip]

In general, I think it would be better to have a smaller regression
test that focuses *only* on the functionality of output-suffix.
Something like

  \version "2.13.5"

  \header {
    texidoc = "description"
  }

  #(define output-suffix "áâéŅ")
  \book {
    \score {
      \new Staff \relative c' {
        c1
      }
      \layout { }
      \midi { }
    }
  }

would be very minimal.  It looks like you want to exercise certain
UTF-8 characters, so you can use those instead.  Also, if you do want
to use 6 \book blocks, writing just one note per \book block will keep
the regtest short.

HTH,
Patrick

---
----
Join the Frogs!

Reply | Threaded
Open this post in threaded view
|

Re: Regression test file for Trackers 714 and 832

Ian Hulin
Patrick McCarty wrote:
Hi Ian,

Your patch is saved in ASCII, but it should be saved in UTF-8.  I'll
provide some more comments for you below.
  
It's in UTF-8 on my system here. 
???!!
Thunderbird says it's set to use UTF-8 encoding, so I'm puzzled.  I'll try compressing the revised patch into an archive and see it that gets through unscathed.
On 2009-11-16, Ian Hulin wrote:
  
Ooops.

Here's the patch this time

Sorry for the confusion.
    

[patch follows]

  
From 1d4349effc5fb6fc865ac2be558fc61d44e5bb73 Mon Sep 17 00:00:00 2001
From: Ian Hulin [hidden email]
Date: Sun, 15 Nov 2009 19:58:55 +0000
Subject: [PATCH] Trackers 832 and 714 - add regression test for output file names containing
 extended Latin accents and other UTF-8 characters.
    

Can you make sure the commit summary is concise enough to fit on one
line?  I would recommend something like

  Add regression test for issues 832 and 714.
  
OK.
and after adding two newlines, write and more verbose description, if
necessary, underneath the commit summary.

  
Signed-off-by: Ian Hulin [hidden email]
---
 input/regression/output-filenames-with-accents.ly |  190 +++++++++++++++++++++
    

I think it would be better if this regtest were named
"output-suffix.ly", because that is the only thing you are testing.

  
No it's not.  What's actually being tested is that Lilypond does not produce a gobbledygook name for the back-end processor (e.g. ghostscript) to process. 
What's actually being tested is lilypond's internal replacement for the Scheme format function, which is where Reinhold found the bug.

The output-suffix variable is the means to the end since the the regression tests have to have a descriptive name, and I haven't found a way of re-setting the output name for the file within the source file from Scheme or Lilypond from before Tracker 836 was accepted, and this bug showed up way back.

  
 1 files changed, 190 insertions(+), 0 deletions(-)
 create mode 100644 input/regression/output-filenames-with-accents.ly

diff --git a/input/regression/output-filenames-with-accents.ly b/input/regression/output-filenames-with-accents.ly
new file mode 100644
index 0000000..0625b2f
--- /dev/null
+++ b/input/regression/output-filenames-with-accents.ly
@@ -0,0 +1,190 @@
+\version "2.13.5"
+
+\header {
+  texidoc = "Using extended Latin characters like ?? in
+  output file-names should not cause any problems with
+  backend processors.  We test this here by using such
+  characters in output-suffix"
+  dedication = "Lilypond Regression Test"
+  title = "M?? Vlast"
+  subtitle = "Symphonic Tone Poem Cycle"
+  instrument = "Orchestra"
+  composer = "Bed??ich ??metana"
+  opus = "Opus 64"
    

Is it really necessary to add an excerpt from an actual composition
when you are just testing output-suffix to make sure it works with
various UTF-8 characters?

  
It seemed a very good way of getting representative sample of extended Latin characters.  Not all the accents caused the problem with the back-end processing - e.g. ç is OK, č isn't, ü, û and ú  are OK, ů isn't.
There aren't any bits of actual composition in there, just the names, so no copyright issues.
It's now pruned down to one \book (see below).

  
+}
+\version "2.13.5"
    

You already have a \version statement at the beginning of the file.

  
OK

  
+
+
+globalI = {
+  \key c \major
+  \time 4/4
+}
+
+globalII = {
+  \key e \minor
+  \time 6/8
+}
+globalIII = {
+  \key f \minor
+  \time 4/4
+}
+globalIV = {
+  \key f \major
+  \time 4/4
+}
+globalV = {
+  \key d \minor
+  \time 4/4
+}
+globalVI = {
+  \key d \minor
+  \time 4/4
+}
+
+violinmI = \relative c'' {
+  \globalI
+  c4 c c c |
+}
+"output-suffix" = "Vy??ehrad"
    

For consistency, I would recommend writing this as

  #(define output-suffix "...")

instead.  IMO, it's cleaner and this is how it's used in the
documentation.  The question marks will go away once you have saved
the file in UTF-8.

[snip]
  
I disagree. 
Never drop into Scheme if it can be avoided. 
The bit in the documentation is mega-hard to find, and it's being superseded as the recommended way of doing this by \bookOutputSuffix anyway once the fix for Tracker 836 goes in.
In general, I think it would be better to have a smaller regression
test that focuses *only* on the functionality of output-suffix.
Something like

  \version "2.13.5"

  \header {
    texidoc = "description"
  }

  #(define output-suffix "áâéŅ")
  \book {
    \score {
      \new Staff \relative c' {
	c1
      }
      \layout { }
      \midi { }
    }
  }

would be very minimal.  It looks like you want to exercise certain
UTF-8 characters, so you can use those instead.  Also, if you do want
to use 6 \book blocks, writing just one note per \book block will keep
the regtest short.

HTH,
Patrick

  
Please see the comments above: this isn't just about output-suffix. Output-suffix is the means to the end.
Hmmm... but minimalism is appealing. . .
OK, I've cut it down to one \book block with three different accents in the the output filename.  It takes about two seconds to compile.

Cheers,
Ian

P.S. The .patch file attachment is definitely in UTF-8 as it leaves here.


From 49684654251e101fd26fbd74710903c9896fcf8a Mon Sep 17 00:00:00 2001
From: Ian Hulin <[hidden email]>
Date: Mon, 16 Nov 2009 12:01:54 +0000
Subject: [PATCH] Add regression test for Trackers 832 and 714.

Check that output file names containing extended Latin accents
and other UTF-8 characters do not get mangled by Lilypond before being
passed to the back-end processor, causing ghostscript especially to crash.

Signed-off-by: Ian Hulin <[hidden email]>
---
 input/regression/output-filenames-with-accents.ly |   34 +++++++++++++++++++++
 1 files changed, 34 insertions(+), 0 deletions(-)
 create mode 100644 input/regression/output-filenames-with-accents.ly

diff --git a/input/regression/output-filenames-with-accents.ly b/input/regression/output-filenames-with-accents.ly
new file mode 100644
index 0000000..8ba9d94
--- /dev/null
+++ b/input/regression/output-filenames-with-accents.ly
@@ -0,0 +1,34 @@
+\version "2.13.5"
+
+\header {
+  texidoc = "Using extended Latin characters like Å¡ and č
+  in output file-names should not cause any problems with
+  backend processors.  We test this here by using such
+  characters in output-suffix"
+  
+  dedication = "Lilypond Regression Test"
+  title = "Má Vlast"
+  subtitle = "Symphonic Tone Poem Cycle"
+  instrument = "Orchestra"
+  composer = "Bedřich Å metana"
+  opus = "Opus 64"
+}
+% Set up variables
+globalIV = {\key f \major \time 4/4}
+violinmIV = \relative c'' { \globalIV  d1 | }
+
+%Now produce back-end files with names using extended accents
+
+"output-suffix" = "Z_českých_luhů_a_hájů"
+\book {
+  \header {
+   subsubtitle = "IV. Z českých luhů a hájů"
+  }
+  \score {
+    \new Staff  \violinmIV
+    \layout { }
+    \midi { }
+  }
+}
+
+
--
1.6.3.3


Regression-test-patch.tar.gz (1K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Regression test file for Trackers 714 and 832

Neil Puttock
2009/11/16 Ian Hulin <[hidden email]>:

> OK, I've cut it down to one \book block with three different accents in the
> the output filename.  It takes about two seconds to compile.

How do you know it works as a regression test if you haven't done
`make check' after applying the patch?

This is what happens during testing:

Missing set(['5a/lily-764b2114-systems.count'])
Removing `/home/neil/lilypond/input/regression/out-test/collated-files.texi'
make[2]: *** [out-test/collated-files.texi] Error 1

Looking in out/lybook-testdb/5a we have the following files:

lily-764b2114.log
lily-764b2114.ly
lily-764b2114.profile
lily-764b2114.txt
lily-764b2114-Z___esk__ch_luh___a_h__j__-1.eps
lily-764b2114-Z___esk__ch_luh___a_h__j__.eps
lily-764b2114-Z___esk__ch_luh___a_h__j__.midi
lily-764b2114-Z___esk__ch_luh___a_h__j__-systems.count
lily-764b2114-Z___esk__ch_luh___a_h__j__-systems.tex
lily-764b2114-Z___esk__ch_luh___a_h__j__-systems.texi
lily-764b2114-Z___esk__ch_luh___a_h__j__.texidoc

The main issue is that the filename isn't used directly when
generating the test results: lilypond-book creates a (hopefully)
unique name using part of an MD5 hash based on the snippet's contents,
and as you can see from the above, adding output-suffix breaks the
link between the original snippet and its output files.

Regards,
Neil

---
----
Join the Frogs!

Reply | Threaded
Open this post in threaded view
|

Re: Regression test file for Trackers 714 and 832

Patrick McCarty
In reply to this post by Ian Hulin
On Mon, Nov 16, 2009 at 4:15 AM, Ian Hulin <[hidden email]> wrote:
> Patrick McCarty wrote:
>> Your patch is saved in ASCII, but it should be saved in UTF-8.  I'll
>> provide some more comments for you below.
>
> It's in UTF-8 on my system here.
> ???!!
> Thunderbird says it's set to use UTF-8 encoding, so I'm puzzled.  I'll try
> compressing the revised patch into an archive and see it that gets through
> unscathed.

IIRC, Thunderbird has been mangling attachments for people in certain
situations.  The compressed version got through okay.

>> I think it would be better if this regtest were named
>> "output-suffix.ly", because that is the only thing you are testing.
>
> No it's not.  What's actually being tested is that Lilypond does not produce
> a gobbledygook name for the back-end processor (e.g. ghostscript) to
> process.
> What's actually being tested is lilypond's internal replacement for the
> Scheme format function, which is where Reinhold found the bug.
>
> The output-suffix variable is the means to the end since the the regression
> tests have to have a descriptive name, and I haven't found a way of
> re-setting the output name for the file within the source file from Scheme
> or Lilypond from before Tracker 836 was accepted, and this bug showed up way
> back.

Okay, I'll admit that I didn't look of the tracker issues carefully
enough to realize this.  Sorry.

>> Is it really necessary to add an excerpt from an actual composition
>> when you are just testing output-suffix to make sure it works with
>> various UTF-8 characters?
>
> It seemed a very good way of getting representative sample of extended Latin
> characters.  Not all the accents caused the problem with the back-end
> processing - e.g. ç is OK, č isn't, ü, û and ú  are OK, ů isn't.
> There aren't any bits of actual composition in there, just the names, so no
> copyright issues.
> It's now pruned down to one \book (see below).

Okay, I like that better.

>> For consistency, I would recommend writing this as
>>
>>   #(define output-suffix "...")
>>
>> instead.  IMO, it's cleaner and this is how it's used in the
>> documentation.  The question marks will go away once you have saved
>> the file in UTF-8.
>
> I disagree.
> Never drop into Scheme if it can be avoided.
> The bit in the documentation is mega-hard to find, and it's being superseded
> as the recommended way of doing this by \bookOutputSuffix anyway once the
> fix for Tracker 836 goes in.

Okay, that's fine.  I suppose I was objecting to this because the
Scheme define syntax seems less awkward to me than using double quotes
around a variable name.

-Patrick

---
----
Join the Frogs!

Reply | Threaded
Open this post in threaded view
|

Re: Regression test file for Trackers 714 and 832

Patrick McCarty
In reply to this post by Neil Puttock
On Mon, Nov 16, 2009 at 3:59 PM, Neil Puttock <[hidden email]> wrote:

> 2009/11/16 Ian Hulin <[hidden email]>:
>
>> OK, I've cut it down to one \book block with three different accents in the
>> the output filename.  It takes about two seconds to compile.
>
> How do you know it works as a regression test if you haven't done
> `make check' after applying the patch?
>
> This is what happens during testing:
>
> Missing set(['5a/lily-764b2114-systems.count'])
> Removing `/home/neil/lilypond/input/regression/out-test/collated-files.texi'
> make[2]: *** [out-test/collated-files.texi] Error 1

Oops, I forgot to check this.

> Looking in out/lybook-testdb/5a we have the following files:
>
> lily-764b2114.log
> lily-764b2114.ly
> lily-764b2114.profile
> lily-764b2114.txt
> lily-764b2114-Z___esk__ch_luh___a_h__j__-1.eps
> lily-764b2114-Z___esk__ch_luh___a_h__j__.eps
> lily-764b2114-Z___esk__ch_luh___a_h__j__.midi
> lily-764b2114-Z___esk__ch_luh___a_h__j__-systems.count
> lily-764b2114-Z___esk__ch_luh___a_h__j__-systems.tex
> lily-764b2114-Z___esk__ch_luh___a_h__j__-systems.texi
> lily-764b2114-Z___esk__ch_luh___a_h__j__.texidoc
>
> The main issue is that the filename isn't used directly when
> generating the test results: lilypond-book creates a (hopefully)
> unique name using part of an MD5 hash based on the snippet's contents,
> and as you can see from the above, adding output-suffix breaks the
> link between the original snippet and its output files.

So, is there a way to get this regression test working with lilypond-book?

Thanks,
Patrick

---
----
Join the Frogs!

Reply | Threaded
Open this post in threaded view
|

Re: Regression test file for Trackers 714 and 832

Neil Puttock
2009/11/17 Patrick McCarty <[hidden email]>:

> So, is there a way to get this regression test working with lilypond-book?

I'm afraid I can't think of anything which would help here.

Cheers,
Neil

---
----
Join the Frogs!

Reply | Threaded
Open this post in threaded view
|

Re: Regression test file for Trackers 714 and 832

John Mandereau
Le jeudi 19 novembre 2009 à 22:37 +0000, Neil Puttock a écrit :
> I'm afraid I can't think of anything which would help here.

What about a convoluted (and ugly) thing like writing a regtest that
writes an extra .ly input file and call lilypond on it?  System commands
are already used in other regtests, like in a (disabled?) SVG regtest.

Best,
John

signature.asc (204 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Regression test file for Trackers 714 and 832

Ian Hulin
John Mandereau wrote:
Le jeudi 19 novembre 2009 à 22:37 +0000, Neil Puttock a écrit :
  
I'm afraid I can't think of anything which would help here.
    

What about a convoluted (and ugly) thing like writing a regtest that
writes an extra .ly input file and call lilypond on it?  System commands
are already used in other regtests, like in a (disabled?) SVG regtest.

Best,
John


  

Well, in the interests of KISS (Keep it simple, stupid), for this one we could have minimal stuff but with extended Latin accents in the file name.  However, I can't seem to run a regtest at all here at the moment (even before adding my file to /input/regression).  I've tried cleaning out and rebuilding with make clean, make all, make check.

I get this at the end of the run:
.
.
.
rm -rf /home/ian/Desktop/Development/lilypondrepo/out/test-results
mkdir -p /home/ian/Desktop/Development/lilypondrepo/out/test-results
/home/ian/Desktop/Development/lilypondrepo/scripts/build/out/output-distance --create-images --output-dir /home/ian/Desktop/Development/lilypondrepo/out/test-results input/regression/out-test-baseline input/regression/out-test/
Traceback (most recent call last):
  File "/home/ian/Desktop/Development/lilypondrepo/scripts/build/out/output-distance", line 1261, in <module>
    main()
  File "/home/ian/Desktop/Development/lilypondrepo/scripts/build/out/output-distance", line 1258, in main
    compare_trees (args[0], args[1], name, options.threshold)
  File "/home/ian/Desktop/Development/lilypondrepo/scripts/build/out/output-distance", line 969, in compare_trees
    data.compare_trees (dir1, dir2)
  File "/home/ian/Desktop/Development/lilypondrepo/scripts/build/out/output-distance", line 812, in compare_trees
    (root, dirs, files) = os.walk (dir1).next ()
StopIteration
make: *** [local-check] Error 1


The new .ly file compiles OK here locally, but I can't tell if it works using make check. 

I've attached it here to see if anyone can get it to work as part of the regression tests.

Cheers,

Ian




\version "2.13.5"

\header {
  texidoc = "Using extended Latin characters like Å¡ and č
  in output file-names should not cause any problems with
  backend processors."
 
  dedication = "Lilypond Regression Test"
  title = "Má Vlast"
  subtitle = "Symphonic Tone Poem Cycle"
  instrument = "Orchestra"
  composer = "Bedřich Å metana"
  opus = "Opus 64"
}
% Set up variables
globalIV = {\key f \major \time 4/4}
violinmIV = \relative c'' { \globalIV  d1 | }

%Now produce back-end files with names using extended accents

\book {
  \header {
   subsubtitle = "IV. Z českých luhů a hájů"
  }
  \score {
    \new Staff  \violinmIV
    \layout { }
    \midi { }
  }
}


Reply | Threaded
Open this post in threaded view
|

Re: Regression test file for Trackers 714 and 832

Neil Puttock
2009/11/23 Ian Hulin <[hidden email]>:

> Well, in the interests of KISS (Keep it simple, stupid), for this one we
> could have minimal stuff but with extended Latin accents in the file name.
> However, I can't seem to run a regtest at all here at the moment (even
> before adding my file to /input/regression).  I've tried cleaning out and
> rebuilding with make clean, make all, make check.

You must run `make test-baseline' before applying the patch.

http://lilypond.org/doc/v2.13/Documentation/topdocs/INSTALL#Testing-LilyPond

> I've attached it here to see if anyone can get it to work as part of the
> regression tests.

I'm sure it would work, but it's not likely to be useful for the
reasons I mentioned previously.  John's suggestion is probably the
only way around this.

Cheers,
Neil

---
----
Join the Frogs!