Re: T1247 - Conditionally do (use-modules (ice-9 curried-definitions)) if running with Guile V2, (issue2219044)

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: T1247 - Conditionally do (use-modules (ice-9 curried-definitions)) if running with Guile V2, (issue2219044)

Patrick McCarty
Hi Ian,

I will test your patch shortly.

Thanks,
Patrick


http://codereview.appspot.com/2219044/diff/15001/scm/lily.scm
File scm/lily.scm (right):

http://codereview.appspot.com/2219044/diff/15001/scm/lily.scm#newcode231
scm/lily.scm:231: (_ "Guile 1.8\n")))))
Okay, I can live with this.  :)

http://codereview.appspot.com/2219044/diff/15001/scm/lily.scm#newcode271
scm/lily.scm:271: (debug-enable 'debug)
On 2010/10/20 21:42:06, ianhulin44 wrote:
> This causes a deprecation warning from Guile V1.9.13 with
> $ declare -x GUILE_WARN_DEPRECATED="detailed"

> [/home/ian/lilypond/out/share/lilypond/current/scm/lily.scm]
> `(debug-enable 'debug)' is obsolete and has no effect.
> Remove it from your code.

Go ahead.  There is another instance of `(debug-enable 'debug)' earlier
in this file, so you can remove that too.

http://codereview.appspot.com/2219044/diff/15001/scm/lily.scm#newcode332
scm/lily.scm:332: (set-module-name! iface (module-name mod))
Please change this so that it uses a tab again.

http://codereview.appspot.com/2219044/diff/15001/scm/lily.scm#newcode338
scm/lily.scm:338: (fresh-interface!))))
This line too.

http://codereview.appspot.com/2219044/

---
----
Join the Frogs!

Reply | Threaded
Open this post in threaded view
|

Re: T1247 - Conditionally do (use-modules (ice-9 curried-definitions)) if running with Guile V2, (issue2219044)

Patrick McCarty
Hi Ian,

I just tested your patch.

In addition to the small tweak that is needed (see my comment below), it
seems that the `(use-modules (ice-9 curried-definitions))' statement
does not carry over to display-lily.scm.  I am a bit puzzled by this.

This is the error message, in context:

;;; compiling
/home/pnorcks/usr/share/lilypond/2.13.37/scm/music-functions.scm
;;; compiling
/home/pnorcks/usr/share/lilypond/2.13.37/scm/display-lily.scm
;;; WARNING: compilation of
/home/pnorcks/usr/share/lilypond/2.13.37/scm/display-lily.scm failed:
;;; key syntax-error, throw args (macroexpand "~a in ~a" ("source
expression failed to match any pattern" (define
((make-music-type-predicate-aux mtypes) expr) (if (null? mtypes) #f (or
(eqv? (car mtypes) (ly:music-property expr (quote name)))
((make-music-type-predicate-aux (cdr mtypes)) expr))))) #f)
;;; WARNING: compilation of
/home/pnorcks/usr/share/lilypond/2.13.37/scm/music-functions.scm failed:
;;; key wrong-type-arg, throw args (#f "Wrong type to apply: ~S" (#f)
(#f))


Fortunately, it seems that the Scheme interpreter in Guile 1.9 is used
as a fallback when compilation fails, since this doesn't interpret the
make process.

Can you reproduce this with Guile 1.9.13?

Thanks,
Patrick


http://codereview.appspot.com/2219044/diff/15001/scm/lily.scm
File scm/lily.scm (right):

http://codereview.appspot.com/2219044/diff/15001/scm/lily.scm#newcode227
scm/lily.scm:227: (use-modules (ice-9 curried-definitions))))
In this section, the parenthesis nesting needs some adjustment.

It should be

   ((guile-v2)
    (if (ly:get-option 'verbose)
        (ly:message  (_ "Using (ice-9 curried-definitions) module\n")))
    (use-modules (ice-9 curried-definitions)))

http://codereview.appspot.com/2219044/

---
----
Join the Frogs!