Re: T1224: Avoid using deprecated %module-public-interface in initialization (issue2083043)

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: T1224: Avoid using deprecated %module-public-interface in initialization (issue2083043)

Neil Puttock
LGTM.


http://www.codereview.appspot.com/2083043/diff/1/2
File lily/ly-module.cc (right):

http://www.codereview.appspot.com/2083043/diff/1/2#newcode36
lily/ly-module.cc:36: SCM maker =
ly_lily_module_constant("make-module");
ly_lily_module_constant ("make-module");

http://www.codereview.appspot.com/2083043/diff/1/2#newcode38
lily/ly-module.cc:38: /* Look up and call Guile module-export-all! or
Lilypond-defined
LilyPond

http://www.codereview.appspot.com/2083043/diff/1/4
File scm/lily.scm (right):

http://www.codereview.appspot.com/2083043/diff/1/4#newcode200
scm/lily.scm:200: (define-public (guile-v2 )
(guile-v2)

http://www.codereview.appspot.com/2083043/diff/1/4#newcode223
scm/lily.scm:223: (cond-expand
remove

all this belongs in a separate patch

http://www.codereview.appspot.com/2083043/diff/1/4#newcode288
scm/lily.scm:288: (ly:error(_"cannot find: ~A") x))
revert

http://www.codereview.appspot.com/2083043/diff/1/4#newcode846
scm/lily.scm:846: ;; we want the failed-files noticed in the aggregrate
logfile.
it's `notice' (noun), referring to the message below

(though you can fix the typo :)

http://www.codereview.appspot.com/2083043/

---
----
Join the Frogs!

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: T1224: Avoid using deprecated %module-public-interface in initialization (issue2083043)

Neil Puttock
Thanks, applied.

http://codereview.appspot.com/2083043/

---
----
Join the Frogs!

Loading...