Re: Remove kludge in Module Code to support Guile V1.6 (MODULE_GC_KLUDGE conditional compilation)

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

Re: Remove kludge in Module Code to support Guile V1.6 (MODULE_GC_KLUDGE conditional compilation)

Ian Hulin
Hi Patrick,

On 26/06/10 02:43, Patrick McCarty wrote:

> On Mon, May 17, 2010 at 10:43 AM, Ian Hulin<[hidden email]>  wrote:
>    
>> We have these blocks in our C++ code base:
>> $ git grep -A 5 MODULE_GC_KLUDGE
>> lily/include/ly-module.hh:#define MODULE_GC_KLUDGE
>> lily/include/ly-module.hh-
>> lily/include/ly-module.hh-#endif /* LY_MODULE_HH */
>> lily/include/ly-module.hh-
>> --
>> lily/ly-module.cc:#ifdef MODULE_GC_KLUDGE
>> lily/ly-module.cc-Protected_scm anonymous_modules = SCM_EOL;
>> lily/ly-module.cc-bool perform_gc_kludge;
>> lily/ly-module.cc-#endif
>> lily/ly-module.cc-
>> lily/ly-module.cc-void
>> --
>> lily/ly-module.cc:#ifdef MODULE_GC_KLUDGE
>> lily/ly-module.cc-  for (SCM s = anonymous_modules;
>> lily/ly-module.cc-       scm_is_pair (s);
>> lily/ly-module.cc-       s = scm_cdr (s))
>> lily/ly-module.cc-    {
>> lily/ly-module.cc-      SCM module = scm_car (s);
>> --
>> lily/module-scheme.cc:#ifdef MODULE_GC_KLUDGE
>> lily/module-scheme.cc-  clear_anonymous_modules ();
>> lily/module-scheme.cc-#endif
>> lily/module-scheme.cc-
>> lily/module-scheme.cc-  return SCM_UNSPECIFIED;
>> lily/module-scheme.cc-}
>> $
>> As I understand it, these are to get round problems with Guile pre V1.8,
>> which we no longer support.
>>
>> Please open a tracker so we can delete this code and I will begin work
>> on a patch.
>>      
> Ian,
>
> Sorry for the delay.  I've opened a tracker issue for you here:
>
> http://code.google.com/p/lilypond/issues/detail?id=1155
>
> Thanks,
> Patrick
>    
A patch is available for review on Rietveld  URL:
http://codereview.appspot.com/1744042

Cheers,

Ian

---
----
Join the Frogs!