[PATCH:] Harmonics and ties in tablature

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

[PATCH:] Harmonics and ties in tablature

Marc Hohl
Hello all,

I just uploaded a patch concerning harmonics and ties to rietveld:

http://codereview.appspot.com/1669041


Just some comments:

I changed the hard-coded values for the harmonic parentheses
to grob properties and added 'whiteout, because the tab note heads can
be drawn
with or without 'whiteout, so the harmonic brackets should be able to
adapt this behavior.

Thanks to Neil, I found a solution for tied tab note heads that are
invisible.
I use the HarmonicParenthesesItem 'after-line-breaking callback, because the
visibility of fret numbers (and therefore for the <>s) depends on the
final position.

The patch isn't 100% correct yet. If you compile the new regression
file, the
fret number disappears in the second line. In larger documents, the number
seems to (dis)appear at random - I don't know why this happens.

Thanks in advance for your comments!

PS: for personal clarification: Since I am not a native speaker, I am
not sure
when I should use "parentheses" or "brackets". These () are parentheses,
and these <> are angled parentheses, isn't it? What's the difference to
brackets,
or can I use this as a synonym?

Marc




---
----
Join the Frogs!

Reply | Threaded
Open this post in threaded view
|

Re: [PATCH:] Harmonics and ties in tablature

Neil Puttock
On 13 June 2010 09:34, Marc Hohl <[hidden email]> wrote:

> The patch isn't 100% correct yet. If you compile the new regression file,
> the
> fret number disappears in the second line. In larger documents, the number
> seems to (dis)appear at random - I don't know why this happens.

The TabNoteHead and HarmonicParenthesesItem have the same default
'layer, which leads to the hamonic brackets sometimes being applied
after the note head.

> PS: for personal clarification: Since I am not a native speaker, I am not
> sure
> when I should use "parentheses" or "brackets". These () are parentheses,
> and these <> are angled parentheses, isn't it?

I'd call <> angle brackets (or "less than" & "greater than").

The harmonic brackets look more like chevrons than parentheses.

Cheers,
Neil

---
----
Join the Frogs!

Reply | Threaded
Open this post in threaded view
|

Re: [PATCH:] Harmonics and ties in tablature

Marc Hohl
Neil Puttock schrieb:

> On 13 June 2010 09:34, Marc Hohl <[hidden email]> wrote:
>
>  
>> The patch isn't 100% correct yet. If you compile the new regression file,
>> the
>> fret number disappears in the second line. In larger documents, the number
>> seems to (dis)appear at random - I don't know why this happens.
>>    
>
> The TabNoteHead and HarmonicParenthesesItem have the same default
> 'layer, which leads to the hamonic brackets sometimes being applied
> after the note head.
>
>  
I see, but within the parenthesize-tab-note-head routine,
the stencil is completely rebuilt from scratch and replaces the
standard tab note head, or am I missing something?
>> PS: for personal clarification: Since I am not a native speaker, I am not
>> sure
>> when I should use "parentheses" or "brackets". These () are parentheses,
>> and these <> are angled parentheses, isn't it?
>>    
>
> I'd call <> angle brackets (or "less than" & "greater than").
>  
Ok, thanks!

Marc


---
----
Join the Frogs!

Reply | Threaded
Open this post in threaded view
|

Re: [PATCH:] Harmonics and ties in tablature

Neil Puttock
On 13 June 2010 16:46, Marc Hohl <[hidden email]> wrote:

> I see, but within the parenthesize-tab-note-head routine,
> the stencil is completely rebuilt from scratch and replaces the
> standard tab note head, or am I missing something?

Yes, but there's still an ordinary HarmonicParenthesesItem underneath
(or in this case, above :) the overridden notehead.

Cheers,
Neil

---
----
Join the Frogs!

Reply | Threaded
Open this post in threaded view
|

Re: [PATCH:] Harmonics and ties in tablature

Ian Hulin
In reply to this post by Marc Hohl
Hi Marc,
On 13/06/10 09:34, Marc Hohl wrote:

> Hello all,
> ...
> <snip>
> ...
> PS: for personal clarification: Since I am not a native speaker, I am
> not sure
> when I should use "parentheses" or "brackets". These () are parentheses,
> and these <> are angled parentheses, isn't it? What's the difference
> to brackets,
> or can I use this as a synonym?

Ok Marc, and other non-native English-speakes for clarity:

all () <> {} [] pairings are *brackets*

     () 'round brackets' or parentheses (singular, parenthesis)
<> 'angle brackets'
     {} 'curly brackets' or braces
     [] 'square brackets'

Cheers,

Ian

---
----
Join the Frogs!

Reply | Threaded
Open this post in threaded view
|

Re: [PATCH:] Harmonics and ties in tablature

Carl Sorensen



On 6/14/10 1:01 PM, "Ian Hulin" <[hidden email]> wrote:

> Hi Marc,
> On 13/06/10 09:34, Marc Hohl wrote:
>> Hello all,
>> ...
>> <snip>
>> ...
>> PS: for personal clarification: Since I am not a native speaker, I am
>> not sure
>> when I should use "parentheses" or "brackets". These () are parentheses,
>> and these <> are angled parentheses, isn't it? What's the difference
>> to brackets,
>> or can I use this as a synonym?
>
> Ok Marc, and other non-native English-speakes for clarity:
>
> all () <> {} [] pairings are *brackets*
>
>      () 'round brackets' or parentheses (singular, parenthesis)
> <> 'angle brackets'
>      {} 'curly brackets' or braces
>      [] 'square brackets'

This terminology is not quite the same in the US.  In the US we don't use
the term "round brackets" at all, and "bracket" means "square bracket".

For LilyPond, I recommend that we use the following:

() parentheses -- both US and UK english recognize this term.
{} braces (preferred) or curly brackets
<> angle brackets
[] square brackets (even though as a US speaker, I don't like this term,
it's less subject to confusion than the normal US term "bracket").

Thanks,

Carl

>
> Cheers,
>
> Ian
>
> ---
> ----
> Join the Frogs!
>


---
----
Join the Frogs!

Reply | Threaded
Open this post in threaded view
|

Re: [PATCH:] Harmonics and ties in tablature

Marc Hohl
Carl Sorensen schrieb:

>
> On 6/14/10 1:01 PM, "Ian Hulin" <[hidden email]> wrote:
>
>  
>> Hi Marc,
>> On 13/06/10 09:34, Marc Hohl wrote:
>>    
>>> Hello all,
>>> ...
>>> <snip>
>>> ...
>>> PS: for personal clarification: Since I am not a native speaker, I am
>>> not sure
>>> when I should use "parentheses" or "brackets". These () are parentheses,
>>> and these <> are angled parentheses, isn't it? What's the difference
>>> to brackets,
>>> or can I use this as a synonym?
>>>      
Ian, Carl, thank you for clarification!

>> Ok Marc, and other non-native English-speakes for clarity:
>>
>> all () <> {} [] pairings are *brackets*
>>
>>      () 'round brackets' or parentheses (singular, parenthesis)
>> <> 'angle brackets'
>>      {} 'curly brackets' or braces
>>      [] 'square brackets'
>>    
>
> This terminology is not quite the same in the US.  In the US we don't use
> the term "round brackets" at all, and "bracket" means "square bracket".
>
> For LilyPond, I recommend that we use the following:
>
> () parentheses -- both US and UK english recognize this term.
> {} braces (preferred) or curly brackets
> <> angle brackets
> [] square brackets (even though as a US speaker, I don't like this term,
> it's less subject to confusion than the normal US term "bracket").
>  
Ok, now I'll know what to use (and "brackets" is faster to type than
"parentheses") ;-)

Thank you,

Marc

> Thanks,
>
> Carl
>
>  
>> Cheers,
>>
>> Ian
>>
>> ---
>> ----
>> Join the Frogs!
>>
>>    
>
>
> ---
> ----
> Join the Frogs!
>
>
>  


---
----
Join the Frogs!